Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20803#discussion_r174038997
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala ---
    @@ -34,6 +34,16 @@ object SQLExecution {
     
       private val executionIdToQueryExecution = new ConcurrentHashMap[Long, 
QueryExecution]()
     
    +  private val executionIdToSqlText = new ConcurrentHashMap[Long, String]()
    +
    +  def setSqlText(sqlText: String): Unit = {
    +    executionIdToSqlText.putIfAbsent(_nextExecutionId.get(), sqlText)
    --- End diff --
    
    Does the executionId used here match the current execution? IIUC, the  
execution id is incremented in `withNewExecutionId`, and the one you used here 
mostly refers to the previous execution, please correct me if I'm wrong.
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to