Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/20799#discussion_r174123402
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala
---
@@ -247,6 +241,18 @@ private[yarn] class ExecutorRunnable(
System.getenv().asScala.filterKeys(_.startsWith("SPARK"))
.foreach { case (k, v) => env(k) = v }
+
+ sparkConf.getExecutorEnv.foreach { case (key, value) =>
+ if (key == Environment.CLASSPATH.name()) {
--- End diff --
there are other variables that requires the append, like LD_LIBRARY_PATH.
It obviously can do bad things if its specified twice though but generally you
shouldn't be doing that.
Maybe I missed it in the description exactly how is AM env taking
presendence? Can you please describe the flow as to why moving this or
changing it fixes the bug (how is executor getting am env now)?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
