Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20849#discussion_r175283674
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
 ---
    @@ -85,6 +85,12 @@ private[sql] class JSONOptions(
     
       val multiLine = 
parameters.get("multiLine").map(_.toBoolean).getOrElse(false)
     
    +  /**
    +   * Standard charset name. For example UTF-8, UTF-16 and UTF-32.
    +   * If charset is not specified (None), it will be detected automatically.
    --- End diff --
    
    > Could you tell me how this PR blocks solving the problem in Hadoop's 
LineReader?
    
    Because the exposed `charset` option is incomplete here because the 
encodings.
    Also, I want to see how we can solve that problem in SPARK-23724 first too. 
I am actually not quite worried of the whole changes proposed here for now.
    
    Why don't we just fix that problem first if you plan to fix both eventually 
anyway?



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to