Github user manku-timma commented on a diff in the pull request: https://github.com/apache/spark/pull/20851#discussion_r175327686 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -72,6 +82,15 @@ private[parquet] object ParquetFilters { (n: String, v: Any) => FilterApi.notEq( binaryColumn(n), Option(v).map(b => Binary.fromReusedByteArray(v.asInstanceOf[Array[Byte]])).orNull) + case DateType if SQLConf.get.parquetFilterPushDownDate => + (n: String, v: Any) => { + FilterApi.notEq( + intColumn(n), + Option(v).map { date => --- End diff -- These 3 lines are repeated several times in this change. Please refactor to a new method.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org