Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19108#discussion_r175521761
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala ---
    @@ -0,0 +1,103 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.ml.stat
    +
    +import scala.annotation.varargs
    +
    +import org.apache.spark.annotation.{Experimental, Since}
    +import org.apache.spark.ml.util.SchemaUtils
    +import org.apache.spark.mllib.stat.{Statistics => OldStatistics}
    +import org.apache.spark.rdd.RDD
    +import org.apache.spark.sql.{DataFrame, Row}
    +import org.apache.spark.sql.functions.col
    +
    +/**
    + * :: Experimental ::
    + *
    + * Conduct the two-sided Kolmogorov Smirnov (KS) test for data sampled 
from a
    + * continuous distribution. By comparing the largest difference between 
the empirical cumulative
    + * distribution of the sample data and the theoretical distribution we can 
provide a test for the
    + * the null hypothesis that the sample data comes from that theoretical 
distribution.
    + * For more information on KS Test:
    + * @see <a 
href="https://en.wikipedia.org/wiki/Kolmogorov%E2%80%93Smirnov_test";>
    + * Kolmogorov-Smirnov test (Wikipedia)</a>
    + */
    +@Experimental
    +@Since("2.4.0")
    +object KolmogorovSmirnovTest {
    +
    +  /** Used to construct output schema of test */
    +  private case class KolmogorovSmirnovTestResult(
    +      pValues: Double,
    +      statistics: Double)
    --- End diff --
    
    statistics -> statistic


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to