Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/20858#discussion_r175527998
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -408,6 +408,7 @@ object FunctionRegistry {
expression[MapValues]("map_values"),
expression[Size]("size"),
expression[SortArray]("sort_array"),
+ expression[ConcatArrays]("concat_arrays"),
--- End diff --
I've already played with this option in my mind, but I'm not sure how
concat would be categorized.
Currently, concat is defined as a pure string operation:
/**
* @group string_funcs
* @since 1.5.0
*/
@scala.annotation.varargs
def concat(exprs: Column*): Column
Whereas the functionality in this PR belongs rather to the collection_funcs
group.
Having just one function for both expressions would be elegant, but can you
advise what group should be assigned to concat?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
