Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/19222
  
    Looks pretty good! My major concern is, the semantic of offset in 
`MemoryBlock.getXXX` should be implementation independent. Users should always 
assume the offset starts with 0. Since it's about API/semantic, it's better to 
do it right at the first place. Thanks for working on it!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to