Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20433#discussion_r175625855
  
    --- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
    @@ -616,18 +616,22 @@ booleanValue
         ;
     
     interval
    -    : INTERVAL intervalField*
    +    : INTERVAL? intervalField+
         ;
     
     intervalField
    -    : value=intervalValue unit=identifier (TO to=identifier)?
    +    : value=intervalValue unit=intervalUnit (TO to=identifier)?
    --- End diff --
    
    right, I checked the hive parser and it seems to handle `TO` as units. But, 
this is an refactoring issue, so is it okay to include this fix in this pr? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to