Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20827#discussion_r175881819
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
 ---
    @@ -288,6 +288,7 @@ trait NonSQLExpression extends Expression {
       final override def sql: String = {
         transform {
           case a: Attribute => new PrettyAttribute(a)
    +      case a: Alias => PrettyAttribute(a.sql, a.dataType)
    --- End diff --
    
    my argument is, `Alias` is not an attribute, but here we turn alias into a 
special attribute for display. So I think this is corrected.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to