Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20829#discussion_r175910352
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala ---
    @@ -136,34 +172,88 @@ class VectorAssembler @Since("1.4.0") 
(@Since("1.4.0") override val uid: String)
     @Since("1.6.0")
     object VectorAssembler extends DefaultParamsReadable[VectorAssembler] {
     
    +  private[feature] val SKIP_INVALID: String = "skip"
    +  private[feature] val ERROR_INVALID: String = "error"
    +  private[feature] val KEEP_INVALID: String = "keep"
    +  private[feature] val supportedHandleInvalids: Array[String] =
    +    Array(SKIP_INVALID, ERROR_INVALID, KEEP_INVALID)
    +
    +
    +  private[feature] def getLengthsFromFirst(dataset: Dataset[_],
    +                                           columns: Seq[String]): 
Map[String, Int] = {
    +    try {
    +      val first_row = dataset.toDF.select(columns.map(col): _*).first
    --- End diff --
    
    Fix (new) IntelliJ style warnings: "toDF" -> "toDF()"


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to