Github user yucai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20851#discussion_r175989972
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
 ---
    @@ -313,6 +316,36 @@ class ParquetFilterSuite extends QueryTest with 
ParquetTest with SharedSQLContex
         }
       }
     
    +  test("filter pushdown - date") {
    +    implicit class IntToDate(int: Int) {
    --- End diff --
    
    As per @cloud-fan 's suggestion, I have changed 1.d to 1.date, which one is 
perferred? 
    1. "2017-08-18".d
    2. 1.date
    3. "2017-08-18".date


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to