Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2937#discussion_r19378842 --- Diff: core/src/main/java/org/apache/spark/util/collection/Sorter.java --- @@ -587,10 +601,12 @@ private int gallopRight(K key, Buffer a, int base, int len, int hint, Comparator int ofs = 1; int lastOfs = 0; - if (c.compare(key, s.getKey(a, base + hint)) < 0) { + K key1 = s.newKey(); --- End diff -- There is an input parameter called `key`. So this one became `key1`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org