Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20853#discussion_r176154914
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -657,6 +662,30 @@ class SparkSubmitSuite
         conf3.get(PYSPARK_PYTHON.key) should be ("python3.5")
       }
     
    +  test("ambiguous archive mapping results in error message") {
    +    val dir = Utils.createTempDir()
    +    val archive1 = Paths.get(dir.toPath.toString, "first.zip")
    +    val archive2 = Paths.get(dir.toPath.toString, "second.zip")
    +    Files.createFile(archive1)
    +    Files.createFile(archive2)
    +    val jars = "/jar1,/jar2"                 // --jars
    +    val files = "local:/file1,file2"          // --files
    +    // --archives
    --- End diff --
    
    Unnecessary comment. I know the other test has them, but I'd just remove 
these from this new code, since they don't add any useful information.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to