Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20795#discussion_r176299569
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -175,6 +175,8 @@ private[sql] class HiveSessionCatalog(
super.functionExists(name) || hiveFunctions.contains(name.funcName)
}
+ override def externalFunctionExists(name: FunctionIdentifier): Boolean =
functionExists(name)
--- End diff --
Oh, you mean functions like "histogram_numeric" should be regarded as
externalFunction in hiveContext ? I am not sure about this. But if that's
right your current code is OK :)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
