Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20866#discussion_r176307892
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala 
---
    @@ -908,11 +912,39 @@ private[hive] object HiveClientImpl {
         Utils.classForName(name)
           .asInstanceOf[Class[_ <: 
org.apache.hadoop.hive.ql.io.HiveOutputFormat[_, _]]]
     
    +  private def toHiveMetaApiTable(table: CatalogTable): HiveMetaApiTable = {
    +    val sd = new StorageDescriptor
    +    sd.setSerdeInfo(new SerDeInfo)
    +    sd.setNumBuckets(-1)
    +    sd.setBucketCols(new JArrayList[String])
    +    sd.setCols(new JArrayList[FieldSchema])
    --- End diff --
    
    Logically, we can remove more redundant initialization.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to