Github user squito commented on the issue:
https://github.com/apache/spark/pull/20604
@vanzin @sitalkedia @jiangxb1987 I was looking at this code again, and I'd
appreciate your thoughts on how this relates to
[SPARK-21834](https://issues.apache.org/jira/browse/SPARK-21834)
https://github.com/apache/spark/pull/19081
I actually think that SPARK-21834 probably solves the bug I was describing
initially. I hit the bug on 2.2.0, and didn't properly understand the change
of SPARK-21834 when proposing this change. Nonetheless, I still think this fix
is a good one -- it improves code clarity in general and fixes a couple other
minor cases. I'd also link the issues in jira etc. so the relationship is more
clear.
I'd go even further and suggest that with this fix in, we can actually
remove SPARK-21834, as its no longer necessary. its not harmful, but its just
confusing.
thoughts?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
