Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20910#discussion_r177264954
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -211,34 +195,34 @@ private[spark] class KubernetesClientApplication
extends SparkApplication {
}
private def run(clientArguments: ClientArguments, sparkConf: SparkConf):
Unit = {
- val namespace = sparkConf.get(KUBERNETES_NAMESPACE)
+ val appName = sparkConf.getOption("spark.app.name").getOrElse("spark")
// For constructing the app ID, we can't use the Spark application
name, as the app ID is going
// to be added as a label to group resources belonging to the same
application. Label values are
// considerably restrictive, e.g. must be no longer than 63 characters
in length. So we generate
// a unique app ID (captured by spark.app.id) in the format below.
val kubernetesAppId =
s"spark-${UUID.randomUUID().toString.replaceAll("-", "")}"
val launchTime = System.currentTimeMillis()
val waitForAppCompletion = sparkConf.get(WAIT_FOR_APP_COMPLETION)
- val appName = sparkConf.getOption("spark.app.name").getOrElse("spark")
val kubernetesResourceNamePrefix = {
s"$appName-$launchTime".toLowerCase.replaceAll("\\.", "-")
}
+ val kubernetesConf = KubernetesConf.createDriverConf(
+ sparkConf,
+ appName,
+ kubernetesResourceNamePrefix,
+ kubernetesAppId,
+ clientArguments.mainAppResource,
+ clientArguments.mainClass,
+ clientArguments.driverArgs)
+ val orchestrator = new KubernetesDriverBuilder
--- End diff --
Should be `builder`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
