Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/2685#discussion_r19384176 --- Diff: pom.xml --- @@ -95,6 +95,7 @@ <module>sql/catalyst</module> <module>sql/core</module> <module>sql/hive</module> + <module>sql/hive-thriftserver</module> --- End diff -- I think this module gets added already when you run with `-Phive` (see the profile declaration below in this file), we should probably move the `hive` module there as well. I think right now Hive will get built by default, which is wrong. Can we make it so that `sql/hive` and `sql/hive-thriftserver` are only included when you use `-Phive` profile?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org