Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20923#discussion_r177854961
  
    --- Diff: hadoop-cloud/pom.xml ---
    @@ -141,13 +93,98 @@
           <artifactId>httpcore</artifactId>
           <scope>${hadoop.deps.scope}</scope>
         </dependency>
    +
       </dependencies>
     
       <profiles>
     
    +    <!-- this inner profile is the default one and includes openstack and 
aws -->
    +    <profile>
    +      <id>hadoop-2.6</id>
    +      <activation>
    +        <activeByDefault>true</activeByDefault>
    --- End diff --
    
    `activeByDefault` is a little misleading. It only enables the profile if 
you don't explicitly activate any other profiles. 
    
    So if you enable any other profile in the build, this won't be enabled 
automatically. And since the cloud module itself is already under a profile, I 
don't think you can ever trigger this.
    
    Probably will need to be documented in the build docs, or maybe you can 
think of a different solution like enabling the cloud profile via a property 
instead.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to