Github user jose-torres commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20933#discussion_r178235107
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala 
---
    @@ -368,8 +368,7 @@ case class FileSourceScanExec(
         val bucketed =
           selectedPartitions.flatMap { p =>
             p.files.map { f =>
    -          val hosts = getBlockHosts(getBlockLocations(f), 0, f.getLen)
    --- End diff --
    
    Would it make sense to split the refactoring changes into their own PR? 
It's hard to tell at a glance which parts of the change are refactoring and 
which are new V2 implementation.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to