Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20850#discussion_r178421247 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java --- @@ -86,11 +82,23 @@ public void grow(int neededSize) { } } - public void reset() { + byte[] buffer() { + return buffer; + } + + int getCursor() { + return cursor; + } + + void incrementCursor(int val) { --- End diff -- typo, should be `increaseCursor`
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org