Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20935#discussion_r178425464
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnStatsSuite.scala
---
@@ -18,18 +18,35 @@
package org.apache.spark.sql.execution.columnar
import org.apache.spark.SparkFunSuite
+import org.apache.spark.sql.catalyst.expressions.RowOrdering
+import org.apache.spark.sql.catalyst.util.TypeUtils
import org.apache.spark.sql.types._
class ColumnStatsSuite extends SparkFunSuite {
- testColumnStats(classOf[BooleanColumnStats], BOOLEAN, Array(true, false,
0))
- testColumnStats(classOf[ByteColumnStats], BYTE, Array(Byte.MaxValue,
Byte.MinValue, 0))
- testColumnStats(classOf[ShortColumnStats], SHORT, Array(Short.MaxValue,
Short.MinValue, 0))
- testColumnStats(classOf[IntColumnStats], INT, Array(Int.MaxValue,
Int.MinValue, 0))
- testColumnStats(classOf[LongColumnStats], LONG, Array(Long.MaxValue,
Long.MinValue, 0))
- testColumnStats(classOf[FloatColumnStats], FLOAT, Array(Float.MaxValue,
Float.MinValue, 0))
- testColumnStats(classOf[DoubleColumnStats], DOUBLE,
Array(Double.MaxValue, Double.MinValue, 0))
- testColumnStats(classOf[StringColumnStats], STRING, Array(null, null, 0))
- testDecimalColumnStats(Array(null, null, 0))
+ testColumnStats(classOf[BooleanColumnStats], BOOLEAN, Array(true, false,
0, 0, 0))
--- End diff --
Those changes to `testColumnStats` seems unnecessary?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
