Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20862#discussion_r178688855
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -301,7 +301,10 @@ private class ReadableChannelFileRegion(source:
ReadableByteChannel, blockSize:
written
}
- override def deallocate(): Unit = source.close()
+ override def deallocate() {
+ source.close()
+ StorageUtils.dispose(buffer)
--- End diff --
I see,thanks
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
