Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20560#discussion_r179120037
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ---
    @@ -43,11 +43,12 @@ case class ReturnAnswer(child: LogicalPlan) extends 
UnaryNode {
      * This node is inserted at the top of a subquery when it is optimized. 
This makes sure we can
      * recognize a subquery as such, and it allows us to write subquery aware 
transformations.
      */
    -case class Subquery(child: LogicalPlan) extends UnaryNode {
    +case class Subquery(child: LogicalPlan) extends KeepOrderUnaryNode {
       override def output: Seq[Attribute] = child.output
     }
     
    -case class Project(projectList: Seq[NamedExpression], child: LogicalPlan) 
extends UnaryNode {
    +case class Project(projectList: Seq[NamedExpression], child: LogicalPlan)
    --- End diff --
    
    sorry, I don't fully understand what you mean. In 
`ProjectExec.outputOrdering` we are getting the `child.outputOrdering` exactly 
as it is done here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to