Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/2906#issuecomment-60566674
@mengxr thank you for your feedback.
> Is there a paper that you used as reference? If so, please cite it in the
doc.
Yes. I added the comment into the doc.
https://github.com/yu-iskw/spark/commit/6b22f0752d5d692912c1e8a5e3390326e5d8ebc6
> Could you send some performance testing results on dense and sparse
datasets?
I had only tested the performance on dense datasets. You can download the
benchmark result below the URL. However, because I changed the algorithm, I
will test it again. I will send the result to you.
https://issues.apache.org/jira/secure/attachment/12675783/benchmark2.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
