Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20996#discussion_r180341726
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -370,12 +370,10 @@ private[spark] class TaskSchedulerImpl(
}
if (!launchedAnyTask) {
taskSet.abortIfCompletelyBlacklisted(hostToExecutors)
+ } else {
+ hasLaunchedTask = true
--- End diff --
I don't think this is a valid change to make, IIUC `hasLaunchedTask` is to
identify whether there were any resources offered, it should not have anything
to do with the locality mechanism.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
