Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20260#discussion_r180359425
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -787,7 +787,7 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
val storageWithLocation = {
val tableLocation = getLocationFromStorageProps(table)
// We pass None as `newPath` here, to remove the path option in
storage properties.
- updateLocationInStorageProps(table, newPath = None).copy(
+ table.storage.copy(
--- End diff --
So we should remove the TODO comment/work?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
