Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20981#discussion_r180475548
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
    @@ -119,4 +119,28 @@ object InternalRow {
         case v: MapData => v.copy()
         case _ => value
       }
    +
    +  /**
    +   * Returns an accessor for an `InternalRow` with given data type. The 
returned accessor
    +   * actually takes a `SpecializedGetters` input because it can be 
generalized to other classes
    +   * that implements `SpecializedGetters` (e.g., `ArrayData`) too.
    +   */
    +  def getAccessor(dataType: DataType): (SpecializedGetters, Int) => Any = 
dataType match {
    --- End diff --
    
    Perhaps we should move this to the companion object of `SpecializedGetters`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to