Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180615326 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -59,12 +75,7 @@ class JoinOptimizationSuite extends PlanTest { (noCartesian, seq_pair._2) } } - testExtractCheckCross(plan, expectedNoCross) - } - - def testExtractCheckCross - (plan: LogicalPlan, expected: Option[(Seq[(LogicalPlan, InnerLike)], Seq[Expression])]) { - assert(ExtractFiltersAndInnerJoins.unapply(plan) === expected) --- End diff -- If we have multiple conditions, we need the compare them as `Set`.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org