Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r180714835
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -274,3 +279,7 @@ abstract class BinaryNode extends LogicalPlan {
override final def children: Seq[LogicalPlan] = Seq(left, right)
}
+
+abstract class KeepOrderUnaryNode extends UnaryNode {
--- End diff --
OrderPreservingUnaryNode sounds better.
It only makes sense for unary node, so I don't think mixin trait is a good
idea.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
