Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20043#discussion_r180724505
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExprValue.scala
 ---
    @@ -0,0 +1,76 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.expressions.codegen
    +
    +import scala.language.implicitConversions
    +
    +import org.apache.spark.sql.types.DataType
    +
    +// An abstraction that represents the evaluation result of [[ExprCode]].
    +abstract class ExprValue {
    +
    +  val javaType: String
    +
    +  // Whether we can directly access the evaluation value anywhere.
    +  // For example, a variable created outside a method can not be accessed 
inside the method.
    +  // For such cases, we may need to pass the evaluation as parameter.
    +  val canDirectAccess: Boolean
    +
    +  def isPrimitive: Boolean = CodeGenerator.isPrimitiveType(javaType)
    +}
    +
    +object ExprValue {
    +  implicit def exprValueToString(exprValue: ExprValue): String = 
exprValue.toString
    +}
    +
    +// A literal evaluation of [[ExprCode]].
    +class LiteralValue(val value: String, val javaType: String) extends 
ExprValue {
    --- End diff --
    
    why not a case class?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to