GitHub user squito opened a pull request:

    https://github.com/apache/spark/pull/21041

    [SPARK-23962][SQL][TEST] Fix race in currentExecutionIds().

    SQLMetricsTestUtils.currentExecutionIds() was racing with the listener
    bus, which lead to some flaky tests.  Wait till the listener bus is
    empty.
    
    I tested by adding some Thread.sleep()s in SQLAppStatusListener, which
    reproduced the exceptions I saw on Jenkins.  With this change, they went
    away.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/squito/spark SPARK-23962

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21041.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21041
    
----
commit 7108d26648cbb9140ee80a0fcb52c3f969627d7d
Author: Imran Rashid <irashid@...>
Date:   2018-04-11T15:29:28Z

    [SPARK-23962][SQL][TEST] Fix race in currentExecutionIds().
    
    SQLMetricsTestUtils.currentExecutionIds() was racing with the listener
    bus, which lead to some flaky tests.  Wait till the listener bus is
    empty.
    
    I tested by adding some Thread.sleep()s in SQLAppStatusListener, which
    reproduced the exceptions I saw on Jenkins.  With this change, they went
    away.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to