[GitHub] spark pull request #20611: [SPARK-23425][SQL]Support wildcard in HDFS path f...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20611#discussion_r181000918
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
    @@ -304,45 +304,14 @@ case class LoadDataCommand(
           }
         }
     
    -    val loadPath =
    +    val loadPath = {
           if (isLocal) {
             val uri = Utils.resolveURI(path)
    -        val file = new File(uri.getPath)
    -        val exists = if (file.getAbsolutePath.contains("*")) {
    -          val fileSystem = FileSystems.getDefault
    -          val dir = file.getParentFile.getAbsolutePath
    -          if (dir.contains("*")) {
    -            throw new AnalysisException(
    -              s"LOAD DATA input path allows only filename wildcard: $path")
    -          }
    -
    -          // Note that special characters such as "*" on Windows are not 
allowed as a path.
    --- End diff --
    
    But I wonder if it's safe to get rid of this whole logic. Just realised 
that I wrote this. I believe this one is related with:
    
    ```
    org.apache.spark.sql.hive.execution.SQLQuerySuite
    org.apache.spark.sql.hive.execution.WindowQuerySuite
    ```
    
    on Windows. I can trigger tests on Windows. Let's see if they pass:
    
    Build started: [SQL] `org.apache.spark.sql.hive.execution.SQLQuerySuite` 
[![PR-20611](https://ci.appveyor.com/api/projects/status/github/spark-test/spark?branch=45A91D8E-AFF8-4615-A5D2-09DFD224440B&svg=true)](https://ci.appveyor.com/project/spark-test/spark/branch/45A91D8E-AFF8-4615-A5D2-09DFD224440B)
    
    Build started: [SQL] `org.apache.spark.sql.hive.execution.WindowQuerySuite` 
[![PR-20611](https://ci.appveyor.com/api/projects/status/github/spark-test/spark?branch=C8762134-C19A-422E-A716-4E072B71120A&svg=true)](https://ci.appveyor.com/project/spark-test/spark/branch/C8762134-C19A-422E-A716-4E072B71120A)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org