Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21004#discussion_r181283769
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ---
    @@ -552,6 +523,40 @@ case class DataSource(
             sys.error(s"${providingClass.getCanonicalName} does not allow 
create table as select.")
         }
       }
    +
    +  /** Returns an [[InMemoryFileIndex]] that can be used to get partition 
schema and file list. */
    +  private def createInMemoryFileIndex(globbedPaths: Seq[Path]): 
InMemoryFileIndex = {
    --- End diff --
    
    No, we can't. In some case we need to check the glob files, while we don't 
need to create `InMemoryFileIndex`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to