Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2871#discussion_r19455214
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -173,15 +175,21 @@ private[spark] class TorrentBroadcast[T:
ClassTag](obj: T, id: Long)
val time = (System.nanoTime() - start) / 1e9
logInfo("Reading broadcast variable " + id + " took " + time + "
s")
--- End diff --
+1. I've seen several cases where this type of human-friendly formatting
has resulted in log messages that report things like "spilling 0 MB to disk" or
"task took 0 seconds", which isn't helpful while debugging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
