Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21083#discussion_r182032397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala
---
@@ -54,13 +51,42 @@ trait QueryPlanConstraints { self: LogicalPlan =>
* See [[Canonicalize]] for more details.
*/
protected def validConstraints: Set[Expression] = Set.empty
+}
+
+object ConstraintsUtils {
--- End diff --
nit: in order to follow the pattern I see also for `PredicateHelper`, what
about having a `ConstraintHelper` trait instead of this object?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
