Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/19222
  
    OK thanks please do that. Does TPC-DS even trigger 2 call sites? E.g. 
ByteArrayMemoryBlock and OnHeapMemoryBlock. Even there it might introduce a 
conditional branch after JIT that could lead to perf degradation.
    
    I also really worry about off-heap mode, in which all three callsites can 
exist and lead to massive degradation.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to