Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21031#discussion_r182627739
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
 ---
    @@ -407,6 +407,7 @@ object FunctionRegistry {
         expression[MapKeys]("map_keys"),
         expression[MapValues]("map_values"),
         expression[Size]("size"),
    +    expression[Cardinality]("cardinality"),
    --- End diff --
    
    One question: Do we need `@ExpressionDescription`? If we need this, we may 
need to create `Cardinality` case class that is the same as `Size`. Of course, 
`Cardinality` and `Size` can extend the same parent class.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to