Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21074#discussion_r182651253
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -572,6 +575,16 @@ class TypeCoercionSuite extends AnalysisTest {
Coalesce(Seq(nullLit, floatNullLit, doubleLit, stringLit)),
Coalesce(Seq(Cast(nullLit, StringType), Cast(floatNullLit,
StringType),
Cast(doubleLit, StringType), Cast(stringLit, StringType))))
+
+ ruleTest(rule,
+ Coalesce(Seq(timestampLit, intLit, stringLit)),
+ Coalesce(Seq(Cast(timestampLit, StringType), Cast(intLit,
StringType),
+ Cast(stringLit, StringType))))
+
+ ruleTest(rule,
+ Coalesce(Seq(tsArrayLit, intArrayLit, strArrayLit)),
+ Coalesce(Seq(Cast(tsArrayLit, ArrayType(StringType)),
+ Cast(intArrayLit, ArrayType(StringType)), Cast(strArrayLit,
ArrayType(StringType)))))
--- End diff --
We usually don't add end-to-end tests for type coercion changes, as the
type coercion logic is pretty isolated, it's very unlikely that we can pass the
unit test but not end-to-end test.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
