Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/21078#discussion_r182835834 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -326,7 +326,7 @@ class LinearRegression @Since("1.3.0") (@Since("1.3.0") override val uid: String Instance(label, weight, features) } - val instr = Instrumentation.create(this, dataset) + val instr = Instrumentation.create(this, instances) --- End diff -- Why this change? Is this to match other things inheriting from Predictor? Let's keep dataset since I hope (maybe in 3.0) we can switch everything to create Instrumentation with Datasets instead of RDDs (since Datasets have more info available).
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org