Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20787#discussion_r183221673
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1117,11 +1117,21 @@ case class AddMonths(startDate: Expression,
numMonths: Expression)
}
/**
- * Returns number of months between dates date1 and date2.
+ * Returns number of months between dates `timestamp1` and `timestamp2`.
+ * If `timestamp` is later than `timestamp2`, then the result is positive.
--- End diff --
Nit: timestamp -> timestamp1. Same below.
Nit: These are called date1 and date2 in Python, and also here in the Scala
code. Worth being consistent?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
