Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21125#discussion_r183283144
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -507,7 +507,8 @@ class GeneralizedLinearRegressionSuite extends MLTest
with DefaultReadWriteTest
val trainer = new
GeneralizedLinearRegression().setFamily("poisson").setLink(link)
.setFitIntercept(fitIntercept).setLinkPredictionCol("linkPrediction")
val model = trainer.fit(dataset)
- val actual = Vectors.dense(model.intercept, model.coefficients(0),
model.coefficients(1))
+ val actual = Vectors.dense(model.intercept, model.coefficients(0),
model.coefficients(1),
+ model.summary.deviance)
assert(actual ~= expected(idx) absTol 1e-4, "Model mismatch: GLM
with poisson family, " +
s"$link link and fitIntercept = $fitIntercept (with zero values).")
--- End diff --
```scala
assert(model.summary.deviance ~== residualDeviancesR(idx) absTol 1E-3)
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
