GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/21147
[SPARK-23799][SQL][FOLLOW-UP] FilterEstimation.evaluateInSet produces wrong stats for STRING ## What changes were proposed in this pull request? `colStat.min` AND `colStat.max` are empty for string type. Thus, `evaluateInSet` should not return zero when either `colStat.min` or `colStat.max`. ## How was this patch tested? Added a test case. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gatorsmile/spark cached Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/21147.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21147 ---- commit 9672f92dde505eada20d8102dcd845a5418d37c8 Author: gatorsmile <gatorsmile@...> Date: 2018-04-25T03:59:46Z fix ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org