Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21149#discussion_r183968048
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -755,7 +755,7 @@ case class HashAggregateExec(
}
// generate hash code for key
- val hashExpr = Murmur3Hash(groupingExpressions, 42)
--- End diff --
How about writing comments for the reason why we set the seed value here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
