Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/2841#issuecomment-60820609
Hey @saucam, I took a look at this too because I had tried upgrading to
Parquet 1.6 in a different branch to use decimals. Made a few comments above.
Apart that, this PR doesn't seem to have any tests for the new
functionality (in particular skipping row groups) or for the methods that build
up Parquet filters. Do you mind adding some of those?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
