Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21168#discussion_r184439831
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -675,9 +675,14 @@ private[spark] class ApplicationMaster(args:
ApplicationMasterArguments) extends
val userThread = new Thread {
override def run() {
try {
- mainMethod.invoke(null, userArgs.toArray)
- finish(FinalApplicationStatus.SUCCEEDED,
ApplicationMaster.EXIT_SUCCESS)
- logDebug("Done running users class")
+ if(mainMethod == null) {
--- End diff --
Also, I don't think this can return `null`. It should return no such method
error if not found or return the method.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
