Github user bersprockets commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21169#discussion_r184685378
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -1208,6 +1208,13 @@ object SQLConf {
           .stringConf
           .createWithDefault("")
     
    +  val REJECT_TIMEZONE_IN_STRING = 
buildConf("spark.sql.function.rejectTimezoneInString")
    +    .internal()
    +    .doc("If true, `to_utc_timestamp` and `from_utc_timestamp` return null 
if the input string " +
    +      "contains a timezone part, e.g. `2000-10-10 00:00:00+00:00`.")
    +    .booleanConf
    +    .createWithDefault(true)
    +
    --- End diff --
    
    Why would we need this? Currently, if a user passes '2000-10-10 
00:00:00+00:00' to <to/from>_utc_timestamp, they get the wrong answer. If they 
switch off this setting, they will continue to get the wrong answer rather than 
null. Are we accommodating the users who experienced this bug and are manually 
shifting the result?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to