Github user xuanyuanking commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21177#discussion_r184725980
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
 ---
    @@ -78,7 +81,7 @@ object TPCDSQueryBenchmark extends Logging {
           }
           val numRows = queryRelations.map(tableSizes.getOrElse(_, 0L)).sum
           val benchmark = new Benchmark(s"TPCDS Snappy", numRows, 5)
    -      benchmark.addCase(name) { i =>
    +      benchmark.addCase(s"$name$nameSuffix") { _ =>
    --- End diff --
    
    how about 
    ```
    benchmark.addCase(s"$name$nameSuffix")(_ => 
spark.sql(queryString).collect())
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to