Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21129#discussion_r184768987
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala 
---
    @@ -95,7 +95,9 @@ private[shared] object SharedParamsCodeGen {
           ParamDesc[String]("distanceMeasure", "The distance measure. 
Supported options: 'euclidean'" +
             " and 'cosine'", 
Some("org.apache.spark.mllib.clustering.DistanceMeasure.EUCLIDEAN"),
             isValid = "(value: String) => " +
    -        
"org.apache.spark.mllib.clustering.DistanceMeasure.validateDistanceMeasure(value)")
    +        
"org.apache.spark.mllib.clustering.DistanceMeasure.validateDistanceMeasure(value)"),
    +      ParamDesc[String]("validationIndicatorCol", "the indicator column 
name for indicating " +
    --- End diff --
    
    How about rephrasing the description: "name of the column that indicates 
whether each row is for training or for validation.  False indicates training; 
true indicates validation."


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to