Github user yanlin-Lynn commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21136#discussion_r184858144
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
 ---
    @@ -840,4 +857,9 @@ class UnsupportedOperationsSuite extends SparkFunSuite {
         def this(attribute: Attribute) = this(Seq(attribute))
         override def isStreaming: Boolean = true
       }
    +
    +  case class StreamingRelationV2(output: Seq[Attribute]) extends LeafNode {
    --- End diff --
    
    I have tried to do that, but the code in 
[UnsupportedOperationChecker](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala#L349)
 will fail the UT. So, should I change the checking logic there too?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to